[Tests] Improve testing of FieldSortBuilder #26437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
:Search/Search
|
@jimczi would you mind taking a look since we talked about this already briefly? I got rid of the whole Lucene index setup after our discussion as suggested, this is much clearer. I'll continue with some small additions to the other SortBuilder tests in follow up PRs. |
|
@cbuescher Please see #26395 as |
|
@jimczi thanks, I will rebase before I merge and look at the incoming changes. I will look at the new nested format in a follow up like suggested. There's also things to add to the geo/script tests if possible. |
Currently we don't do much unit testing about the SortField that is created then calling the SortBuilders `build` method. Most of this is covered by integration tests somewhere but it would be good to have some basic checks in FieldSortBuilderTest as well. This adds testing for the sort order, mode, missing values and checks that `nested` gets set in the XFieldComparatorSource when `nestedPath` and `nestedFilter` are set on the builder. Relates to elastic#17286
cbuescher
added a commit
that referenced
this pull request
Aug 31, 2017
Currently we don't have much unit testing about the SortField that is created then calling the SortBuilders `build` method. Most of this is covered by integration tests somewhere but it would be good to have some basic checks in FieldSortBuilderTest as well. This adds testing for the sort order, mode, missing values and checks that `nested` gets set in the XFieldComparatorSource when `nestedPath` and `nestedFilter` are set on the builder. Relates to #17286
cbuescher
added a commit
that referenced
this pull request
Aug 31, 2017
Currently we don't have much unit testing about the SortField that is created then calling the SortBuilders `build` method. Most of this is covered by integration tests somewhere but it would be good to have some basic checks in FieldSortBuilderTest as well. This adds testing for the sort order, mode, missing values and checks that `nested` gets set in the XFieldComparatorSource when `nestedPath` and `nestedFilter` are set on the builder. Relates to #17286
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 31, 2017
* master: Allow abort of bulk items before processing (elastic#26434) [Tests] Improve testing of FieldSortBuilder (elastic#26437) Upgrade to lucene-7.0.0-snapshot-d94a5f0. (elastic#26441) Implement adaptive replica selection (elastic#26128) Build: Quiet bwc build output (elastic#26430) Migrate Search requests to use Writeable reading strategies (elastic#26428) Changed version from 7.0.0-alpha1 to 6.1.0 in the nested sorting serialization check. Remove dead path conf BWC code in build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't do much unit testing about the SortField that is created then calling the
SortBuilders
buildmethod. Most of this is covered by integration tests somewhere but itwould be good to have some basic checks in FieldSortBuilderTest as well.
This adds testing for the sort order, mode, missing values and checks that
nestedgets setin the XFieldComparatorSource when
nestedPathandnestedFilterare set on the builder.Also it is simplifying the setup of the mocked QueryShardContext a bit.
Relates to #17286